This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Introduce CAN reader hierarchy #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophokles73
force-pushed
the
introduce_reader_hierarchy
branch
from
f712907
to
2762eb8
Compare
Increase cohesion and reduce coupling between components by introducing an abstract CANReader class which defines the responsibilities and behavior of the DBCReader and J1939Reader. Modified readers to consistently use HW based CAN frame filtering based on DBC message and DBC<->VSS mapping definitions. Also added typing information to functions and member variables to improve readability and maintainability.
sophokles73
force-pushed
the
introduce_reader_hierarchy
branch
from
2762eb8
to
87e90ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase cohesion and reduce coupling between components by introducing
an abstract CANReader class which defines the responsibilities and
behavior of the DBCReader and J1939Reader.
Modified readers to consistently use HW based CAN frame filtering based
on DBC message and DBC<->VSS mapping definitions.
Also added typing information to functions and member variables to
improve readability and maintainability.