Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove symbol highlighting for generated textmate grammar #292

Closed
msujew opened this issue Nov 9, 2021 · 0 comments · Fixed by #293
Closed

Remove symbol highlighting for generated textmate grammar #292

msujew opened this issue Nov 9, 2021 · 0 comments · Fixed by #293
Labels
highlighting Related to syntax highlighting
Milestone
v0.3.0

Comments

@msujew
Copy link
Member

msujew commented Nov 9, 2021

Usually programming languages for VSCode don't highlight symbols (brackets, parenthesis, etc.) in their textmate grammar. We should align to that decision for our generated textmate grammar.
@msujew msujew added the highlighting Related to syntax highlighting label Nov 9, 2021
@msujew msujew mentioned this issue Nov 9, 2021
Merged
@spoenemann spoenemann added this to the v0.3.0 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
highlighting Related to syntax highlighting
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Correctly escape keywords for textmate and remove symbols eclipse-langium/langium
2 participants
@spoenemann @msujew