Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly escape keywords for textmate and remove symbols #293

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Correctly escape keywords for textmate and remove symbols #293

merged 1 commit into from
Nov 10, 2021

Conversation

msujew
Copy link
Member

@msujew msujew commented Nov 9, 2021

Closes #292

Also fixes a bug that prevents correct highlighting when the input isn't regex escaped.

@msujew msujew requested review from spoenemann and jbicker November 9, 2021 14:31
@msujew msujew added the highlighting Related to syntax highlighting label Nov 9, 2021
spoenemann
spoenemann approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@msujew msujew merged commit 3ec5cf0 into main Nov 10, 2021
@msujew msujew deleted the msujew/textmate-escape-regex branch November 10, 2021 11:28
@msujew msujew mentioned this pull request Feb 2, 2022
Closed
@spoenemann spoenemann added this to the v0.3.0 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@jbicker jbicker Awaiting requested review from jbicker

Assignees
No one assigned
Labels
highlighting Related to syntax highlighting
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Remove symbol highlighting for generated textmate grammar
2 participants
@msujew @spoenemann