feat: Add jsExtension to LangiumConfig
#1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When downstream projects are using `nodenext` module resolution, file extensions are mandatory. So if `jsExtension` is true, a `.js` extension will be added to the ast and grammar imports.
msujew
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
@sidharthv96 Thanks for the contribution. I took the freedom to update the jsExtension to a more general importExtension field, in case someone wants to use .cjs or .mjs style imports.
Is this change blocking for mermaid-js/mermaid#4450? I can create a bugfix release for this for the langium-cli package once this is merged, if you need it.
|
Yup, the value being configurable is better, thank you.
That would be wonderful @msujew, I guess it'll make @Yokozuna59's life a lot easier. 😇 |
24 tasks
spoenemann
pushed a commit
that referenced
this pull request
Aug 15, 2023
When downstream projects are using `nodenext` module resolution, file extensions are mandatory. Developers can use `importExtension` to specify the extension used in generated import statements. --------- Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downstream projects are using
nodenextmodule resolution, file extensions are mandatory.So if
jsExtensionis true, a.jsextension will be added to the ast and grammar imports.PS: I don't really like the
jsExtensionname for the config, should we use something else? Nothing comes to mind.Context: mermaid-js/mermaid#4450 (comment)