Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminal constants #1097

Merged
merged 10 commits into from
Jul 12, 2023
Merged

Add terminal constants #1097

merged 10 commits into from
Jul 12, 2023

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented Jun 27, 2023

  • adds constants for
    • terminal names
    • regular expressions
  • adds tests

@Lotes Lotes marked this pull request as ready for review June 27, 2023 09:40
@Lotes Lotes requested a review from spoenemann June 27, 2023 09:44
msujew
msujew reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please regenerate the projects? Given that the generator has changed, the generated code also has to change.

msujew
msujew reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also perform the bootstrapping? The updated ast.ts in packages/langium is still missing. Just run langium:generate in the project root.

@Lotes Lotes force-pushed the lotes/terminal-constants branch from f40cb8e to ec0c3a6 Compare July 10, 2023 09:04
msujew
msujew reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on top of the latest main? After my changes in #1109, your generator probably needs a bit of fine tuning.

@Lotes Lotes force-pushed the lotes/terminal-constants branch from ec0c3a6 to a072294 Compare July 11, 2023 15:59
msujew
msujew approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@Lotes Lotes merged commit 573aba8 into main Jul 12, 2023
@Lotes Lotes deleted the lotes/terminal-constants branch July 12, 2023 15:27
@spoenemann spoenemann added this to the v2.0.0 milestone Jul 19, 2023
spoenemann pushed a commit that referenced this pull request Aug 15, 2023
@Lotes @spoenemann
Add terminal constants (#1097)
e68059a 
* Add generator for terminals
* Add tests
* Fix import
* Fix type declaration and add newline
* Fix PR comments
* Generate AST for examples
* Unify Regex serialization in AST generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

@spoenemann spoenemann Awaiting requested review from spoenemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Lotes @msujew @spoenemann