Remove "yo" from devDependencies #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
You have to install yo yourself, but that is stated in the guide:
https://langium.org/docs/learn/workflow/install/
The removal of this one removes 373 other packages. Wasn't aware it of this magnitude of dependency pollution.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev dependency to
yoleads to a transitive dependency tolocutus:That package has IP issues: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16274
AFAICT we don't really need that dependency in the repo. The tests work fine with just the
yeoman-testpackage.