Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple document-builder listeners #1738

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

cdietrich
Copy link
Contributor

@cdietrich cdietrich commented Nov 4, 2024

Closes #1740

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@cdietrich cdietrich force-pushed the cd/document-builder-listener-problem branch 2 times, most recently from e91f9ee to 26e3d9f Compare November 4, 2024 18:30
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@cdietrich cdietrich force-pushed the cd/document-builder-listener-problem branch from 26e3d9f to 5c2985f Compare November 4, 2024 18:39
@cdietrich cdietrich requested a review from msujew November 5, 2024 09:46
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation and the fix. I'll likely release a new patch version of Langium (3.2.1) that contains this change in the afternoon 👍

@msujew msujew merged commit 21b1051 into main Nov 5, 2024
5 checks passed
@msujew msujew deleted the cd/document-builder-listener-problem branch November 5, 2024 11:28
msujew pushed a commit that referenced this pull request Nov 5, 2024
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@msujew
Copy link
Member

msujew commented Nov 5, 2024

@cdietrich 3.2.1 is online :)

@cdietrich
Copy link
Contributor Author

nice

@cdietrich
Copy link
Contributor Author

@msujew can you please also push a tag

@msujew
Copy link
Member

msujew commented Nov 6, 2024

@cdietrich Done

@msujew msujew added this to the v3.3.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Completion hangs
2 participants