Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the global maxLookahead configuration #248

Merged
merged 6 commits into from
Sep 30, 2021
Merged

Add the global maxLookahead configuration #248

merged 6 commits into from
Sep 30, 2021

Conversation

pluralia
Copy link
Contributor

Closes the issue/202.
Allows to configure Chevrotain's IParserConfig as part of LangiumConfig; provides a new service ParserConfig similarly to the LanguageMetaData service.

spoenemann
spoenemann reviewed Sep 29, 2021
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/domainmodel/langium-config.json Outdated Show resolved Hide resolved
packages/langium-cli/langium-config-schema.json Outdated Show resolved Hide resolved
packages/langium/src/services.ts Outdated Show resolved Hide resolved
packages/langium-cli/src/generator/module-generator.ts Outdated Show resolved Hide resolved
@pluralia pluralia requested a review from spoenemann September 29, 2021 11:26
@spoenemann spoenemann mentioned this pull request Sep 29, 2021
Closed
spoenemann
spoenemann approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remark and a question, then it's good to merge.

packages/langium/src/parser/langium-parser.ts Outdated Show resolved Hide resolved
packages/langium/src/parser/langium-parser.ts Show resolved Hide resolved
@pluralia pluralia merged commit 62b11df into main Sep 30, 2021
@pluralia pluralia deleted the pluralia/lookahead branch September 30, 2021 07:27
@spoenemann spoenemann added this to the v0.2.0 milestone Sep 30, 2021
@msujew msujew added cli CLI related issue parser Parser related issue labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@msujew msujew Awaiting requested review from msujew

Assignees
No one assigned
Labels
cli CLI related issue parser Parser related issue
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Configure parser lookahead
3 participants
@pluralia @spoenemann @msujew