Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case-insensitive configuration for keywords parsing #316

Merged
merged 13 commits into from
Dec 13, 2021
Merged

Add case-insensitive configuration for keywords parsing #316

merged 13 commits into from
Dec 13, 2021

Conversation

pluralia
Copy link
Contributor

@pluralia pluralia commented Dec 3, 2021

Closes #315.
Adds a flag caseInsensitive in LanguageMetaData.

@pluralia pluralia requested review from spoenemann and msujew December 3, 2021 18:52
spoenemann
spoenemann approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! A few detail remarks below, feel free to merge after addressing them.

packages/langium-cli/src/generator/module-generator.ts Outdated Show resolved Hide resolved
packages/langium/src/parser/token-builder.ts Outdated Show resolved Hide resolved
packages/langium/src/utils/regex-util.ts Outdated Show resolved Hide resolved
examples/arithmetics/example/example.calc Outdated Show resolved Hide resolved
@pluralia pluralia force-pushed the pluralia/case-insensitive branch from 1b5c6ca to 7847284 Compare December 10, 2021 12:13
@pluralia pluralia merged commit 8276ee5 into main Dec 13, 2021
@pluralia pluralia deleted the pluralia/case-insensitive branch December 13, 2021 10:41
@spoenemann spoenemann added this to the v0.3.0 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@msujew msujew Awaiting requested review from msujew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Add case-insensitive configuration for keywords parsing
2 participants
@pluralia @spoenemann