-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types declaration #406
Conversation
2806ebb
to
c26fc0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pluralia! At first glance this looks good. I'll have a more in-depth look later, here are a few initial remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking fantastic, thanks 👍
I noticed that highlighting of return types for terminal rules does no longer work as expected. You should replace this code:
With this:
} else if ((isParserRule(node) && isDataTypeRule(node) || isTerminalRule(node)) && node.type?.name) {
acceptor({
node: node.type,
feature: 'name',
type: SemanticTokenTypes.type
});
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this! We need to work on a few basic validations, then release v0.3.0 is ready to go.
b768b5c
to
a3c99bd
Compare
interface
andtype
syntaxReturnType
& adds it to the scope for cross-references@
and arrays as[]
(for example,@MyType[]
means an array of references onMyType
)