Use document paths for json serializer references #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
reviewed
Nov 29, 2022
spoenemann
reviewed
Nov 29, 2022
msujew
force-pushed
the
msujew/json-serialize-reference
branch
from
bb8c724 to
888f719
Compare
spoenemann
approved these changes
Dec 9, 2022
msujew
force-pushed
the
msujew/json-serialize-reference
branch
from
3695a41 to
6b723bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate grammar loading without resorting to using the linker, we now use document paths for the json serializer. This makes some functions async which were previously sync, but these were used for testing purposes only anyway.
Also introduces a function to copy AST nodes, as we now need deep copies of AST nodes for the langium-cli to correctly embed referenced grammars.