Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources 13 to 20 aren't implemented in leshan server #1393

Closed
Warmek opened this issue Feb 3, 2023 · 13 comments
Closed

Resources 13 to 20 aren't implemented in leshan server #1393

Warmek opened this issue Feb 3, 2023 · 13 comments
Labels
question Any question about leshan

Comments

@Warmek
Copy link
Contributor

Warmek commented Feb 3, 2023

Question

Some lwm2m resources from Server object are missing on Leshan Bootstrap module.
For lwm2m Server object on Leshan side all resources are implemented excepted resources from 13 to 20. Resources from 21 onwards seems to be present.

@Warmek Warmek added the question Any question about leshan label Feb 3, 2023
@sbernard31
Copy link
Contributor

sbernard31 commented Feb 3, 2023

Yep, this is not implemented because there is an issue with model from registry.

All those resources are declared as EXECUTABLE resource.
This is a bug in the model, See : OpenMobileAlliance/lwm2m-registry#519

If you read issue ☝️ and as OMA doesn't want to fix their model, you will see there is no clear consensus about what should be the best move for Leshan 😞

Your issue description looks just like a "fact" statement but is there some needs behind this ? could you elaborate a bit more ?

@Warmek
Copy link
Contributor Author

Warmek commented Feb 3, 2023

The question would be if we can implement those resources and if so how to do it? But from what i understand it seems that this will not be possible

@sbernard31
Copy link
Contributor

Not impossible but at least we need to think about pros and cons before to implement it.

If you strongly need it, it may worth to find a solution.
else maybe better to let it like this for now and then implement it for Leshan 3.x which will target LWM2M v1.2.

@sbernard31
Copy link
Contributor

@Warmek so do you need this feature OR this was just for sake of completeness ?

@Warmek
Copy link
Contributor Author

Warmek commented Feb 17, 2023

I would like have this feature implemented especially as right now operations those fields aren't defined and becouse of this we can change them to for example read and it wouldn't affect compability. Also it would give those fields some usage as right now we can't do anything with them

@sbernard31
Copy link
Contributor

sbernard31 commented Feb 17, 2023

I still don't get if :

  • you really need it in a specific production use case
  • OR you just think it will be better for Leshan in a general way.

Anyway, I get your point and I think it makes sense.

it wouldn't affect compatibility.

Probably right, there is not so much interoperability issue as :

  • without the fixed model, those resources are unusable,
  • if server has fixed model and client not, client will just answer Method not allowed
  • if client has fixed model and server not, there is poor chances that someone tries to send anything on those resource and even if this is done we will just have a Not found or Method not allowed.

But before to jump on this, I try to get feedback from OMA : OpenMobileAlliance/lwm2m-registry#519 (comment)

@sbernard31
Copy link
Contributor

Just for the update : OpenMobileAlliance/lwm2m-registry#519 (comment)

@Warmek, if wanted you can start to work on this.
I guess first thing to do is to fixed the model 1-1_1.xml
You should probably looking at 1-1_2.xml for buggy resources.

I think we should also probably rename that file into something like 1-1_1-fixed.xml

@sbernard31
Copy link
Contributor

Some news from OMA : OpenMobileAlliance/lwm2m-registry#519 (comment)
Following this ☝️, no need to use a different model. (I don't know if this will be an issue with Leshan code, we will see)

@Warmek
Copy link
Contributor Author

Warmek commented Mar 28, 2023

I've created xml-fixed with 1-1_1-fixed.xml file. I've implemented same operations as OMA did in their fix

@sbernard31
Copy link
Contributor

In my last commit just above (#1393 (comment)), I said that finally "no need to use a different model"
So unless you find some issue about keeping previous model, we should first try to follow OMA advices.

@Warmek
Copy link
Contributor Author

Warmek commented Apr 4, 2023

OMA said that those resources are supposed to be set in Bootstrap. I've added them to ServerConfig in BootstrapConfig.java.
I've made a commit on opl/AddBootstrapAttributes.

@sbernard31
Copy link
Contributor

I think this is the right way.
Did you test it ?
You can create a PR about this.

@sbernard31
Copy link
Contributor

This is now integrated in master thx to PR #1435.
I guess we can close this issue.

Thx @Warmek to moved this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Any question about leshan
Projects
None yet
Development

No branches or pull requests

2 participants