Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating an unsuccessful ReadCompositeResponse #1674

Closed
slaft opened this issue Nov 18, 2024 · 7 comments · Fixed by #1676
Closed

Error when creating an unsuccessful ReadCompositeResponse #1674

slaft opened this issue Nov 18, 2024 · 7 comments · Fixed by #1676
Labels
bug Dysfunctionnal behavior

Comments

@slaft
Copy link

slaft commented Nov 18, 2024

Version(s)

2.0.0-M17

Which components

server and client

Tested With

No response

What happened

This exception is thrown when the client/server tries to create an unsuccessful ReadCompositeResponse:
IllegalArgumentException content OR timestampedValue should be not null

(Same for an ObserveCompositeResponse and CancelCompositeObservationResponse).

How to reproduce

No response

Relevant Output

No response

@sbernard31
Copy link
Contributor

This should be fixed by : #1676

Let me know if this is easier for you to test if I integrate it directly in master ?

@sbernard31
Copy link
Contributor

Oops @JaroslawLegierski I just see that you also work on it : JaroslawLegierski@7803d95

We should improve communication, let me know when you work on something 🙂

@slaft
Copy link
Author

slaft commented Nov 20, 2024

Yes that's ok, thanks

@sbernard31
Copy link
Contributor

Yes that's ok, thanks

Just to be sure 🙂

That's means :

  1. That's ok, I can test it without you to integrate it in master
  2. OR That's ok, I tested it and all tests pass now ?

@slaft
Copy link
Author

slaft commented Nov 21, 2024

Sorry my answer wasn't clear at all 🙂, I meant that all the tests pass now.

@sbernard31
Copy link
Contributor

Oh great thx 🙏

@JaroslawLegierski
Copy link
Contributor

Oops @JaroslawLegierski I just see that you also work on it : JaroslawLegierski@7803d95

We should improve communication, let me know when you work on something 🙂

Sure, I should have informed you earlier. I prepared only the first proposal on how we can solve this problem, but you were faster. 😅 Currently I'm working on #1504.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Dysfunctionnal behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants