Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting selected code doesn't work anymore, the whole file is formatted instead #1127

Closed
travkin79 opened this issue Oct 1, 2024 · 2 comments
Closed

Formatting selected code doesn't work anymore, the whole file is formatted instead #1127

travkin79 opened this issue Oct 1, 2024 · 2 comments

Comments

@travkin79
Copy link
Contributor

Issue
If you select some text in an LSP-based text editor and then you use the shortcut for formatting code (Ctrl + Shift + F on PCs), then the whole file is formatted instead of formatting the selected text only.
@travkin79
Copy link
Contributor Author

travkin79 commented Oct 1, 2024 •
edited
Loading

See https://github.com/eclipse/lsp4e/blob/e3404b4cb632c261d5a7c217a96124a83084c168/org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/format/LSPFormatter.java#L58-L67

According to this code, the range parameters (the given text selection) are only used if the LS does not support document formatting and if the text selection has length 0. That does not make sense to me.

It seems the last change on LSPFormatter accidentally changed the conditions.

travkin79 added a commit to travkin79/lsp4e that referenced this issue Oct 1, 2024
@travkin79
Fix selective formatting (eclipse-lsp4e#1127)
20afadd
travkin79 added a commit to travkin79/lsp4e that referenced this issue Oct 1, 2024
@travkin79
Fix selective formatting (eclipse-lsp4e#1127)
9c9541f
travkin79 added a commit to travkin79/lsp4e that referenced this issue Oct 2, 2024
@travkin79
Fix selective formatting (eclipse-lsp4e#1127)
f32bf62 
Also adapt mock server to support range formatting and
add tests.
rubenporras pushed a commit that referenced this issue Oct 3, 2024
@travkin79
Fix selective formatting (issue #1127) (#1128)
0324785 
* Fix selective formatting (#1127)

Also adapt mock server to support range formatting and
add tests.

* Bump versions
@travkin79 travkin79 mentioned this issue Oct 8, 2024
Merged
@sebthom
Copy link
Member

sebthom commented Oct 9, 2024

Fixed in LSP4E 0.26.6

@sebthom sebthom closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebthom @travkin79