Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two CodeMiningReconciler are created for one file #273

Closed
angelozerr opened this issue Oct 28, 2022 · 2 comments
Closed

Two CodeMiningReconciler are created for one file #273

angelozerr opened this issue Oct 28, 2022 · 2 comments

Comments

@angelozerr
Copy link
Contributor

When you open a file like JSON, I noticed that there are 2 CodeMiningReconciler which are installed which is very annoying since codemining can be expensive.

The reason about those 2 CodeMiningReconciler is that it is declared in generic editor plugin and lsp4e plugin. I think LSP4e should remove the declaration of code mining provider.

@sebthom
Copy link
Member

sebthom commented Jan 16, 2023

@mickaelistria I can confirm that two instances are created. Any reason to not remove the CodeMiningReconciler from LSP4E?

@mickaelistria
Copy link
Contributor

Any reason to not remove the CodeMiningReconciler from LSP4E?

Not that I remember. Removing it sounds like a good idea.

sebthom added a commit to sebthom/lsp4e that referenced this issue Jan 16, 2023
@sebthom sebthom closed this as completed Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants