lsp4e: Patch so we have access to the rename operations #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not from my side. Any objections, @mickaelistria ? |
|
@mickaelistria , since there are no objections I merge the PR. If you have objections, we can take a look at them nevertheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of getting us off a custom (shaded) version of lsp4e. We use some of the rename classes for a custom rename command initiated via a code lens, but this won't compile with production lsp4e as the package isn't exposed. Any objection to exposing it in the same way as some of the other operations (exposed but marked as private so you get a warning)?