Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing in Eclipse 4.34 hover test #1160

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

BoykoAlex
Copy link
Contributor

The ignored hover has an issue that active part becomes package explorer all of a sudden when hover shell is brought up.
For the test to pass I simply decided to activate the expected editor part manually. After all the test is to verify that intro URL's clicked on the hover are working.

Copy link
Contributor

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at it.

I think you need to update the version of the test plug-in.

@BoykoAlex
Copy link
Contributor Author

@rubenporras yep, just did that :-)

@rubenporras rubenporras merged commit 2dea8df into eclipse-lsp4e:main Dec 10, 2024
4 of 6 checks passed
@rubenporras
Copy link
Contributor

thanks

@rubenporras rubenporras self-requested a review December 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants