feat: support initial folding of license header #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
reviewed
Jan 15, 2025
| @@ -63,6 +64,9 @@ public class LSPFoldingReconcilingStrategy | |||
|
|
|||
| private static final Annotation[] NO_ANNOTATIONS = new Annotation[0]; | |||
|
|
|||
| private static final Pattern LICENSE_KEYWORDS = Pattern | |||
| .compile("(?i)(copyright|licensed under|all rights reserved|SPDX-License-Identifier)"); //$NON-NLS-1$ | |||
There was a problem hiding this comment.
Is this kind of folding not something that should be determined by de server, which can know more about the structure of the language?
There was a problem hiding this comment.
Yes, probably, but the LSP does specify such information at the moment; so we cannot use anything like it so far.
There was a problem hiding this comment.
This was discussed/rejected here microsoft/language-server-protocol#1819
rubenporras
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #884 by adding a new folding option to automatically fold license headers on initial opening of an editor.
If the first foldable comment of a file a license header is determined using a regex
(?i)(copyright|licensed under|all rights reserved|SPDX-License-Identifier)The behaviour is different to Eclipse JDT which has an option to generally fold all header comments:
