Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cycling "LSP4E Linked Editing" job when selecting attribute value #838 #170

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Cycling "LSP4E Linked Editing" job when selecting attribute value #838 #170

merged 1 commit into from
Jul 1, 2022

Conversation

vrubezhny
Copy link
Contributor

Signed-off-by: Victor Rubezhny vrubezhny@redhat.com

@vrubezhny vrubezhny force-pushed the fixJobCreationCyclingInLinkedEditing branch from 95a9177 to aaea252 Compare June 30, 2022 11:56
mickaelistria
mickaelistria approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems good to me, however I didn't try it. If you tested it and are confident it's woring well, feel free to merge.

@vrubezhny vrubezhny force-pushed the fixJobCreationCyclingInLinkedEditing branch from aaea252 to e22b313 Compare June 30, 2022 19:23
@vrubezhny vrubezhny force-pushed the fixJobCreationCyclingInLinkedEditing branch from e22b313 to 9d3f114 Compare July 1, 2022 09:43
@vrubezhny vrubezhny force-pushed the fixJobCreationCyclingInLinkedEditing branch from 9d3f114 to 54e8513 Compare July 1, 2022 09:57
@vrubezhny
Copy link
Contributor Author

Change seems good to me, however I didn't try it. If you tested it and are confident it's woring well, feel free to merge.

Yes, I have tested it manually, I believe it works well.
The problem wasn't appearing in HTML Editor, while for XML Editor the linked regions were returned even if the text cursor is placed into a position outside of element name. Now we're filtering out the position, starting the update job only if position is inside element name.

@vrubezhny vrubezhny merged commit b998ac2 into eclipse-lsp4e:master Jul 1, 2022
@vrubezhny vrubezhny mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebthom sebthom sebthom left review comments

@rubenporras rubenporras rubenporras left review comments

@mickaelistria mickaelistria mickaelistria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrubezhny @sebthom @mickaelistria @rubenporras