Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup and fixes of test cases #277

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Nov 2, 2022

No description provided.

@sebthom sebthom changed the title Minor cleanup of test cases Minor cleanup and fixes of test cases Nov 2, 2022
Copy link
Contributor

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shall I merge?

@sebthom sebthom marked this pull request as draft November 3, 2022 12:28
java.util.ConcurrentModificationException
  at java.base/java.util.ArrayList.forEach(ArrayList.java:1513)
  at org.eclipse.lsp4e.tests.mock.MockLanguageServer.waitBeforeTearDown(MockLanguageServer.java:117)
  at org.eclipse.lsp4e.test.AllCleanRule.clear(AllCleanRule.java:72)
  at org.eclipse.lsp4e.test.AllCleanRule.finished(AllCleanRule.java:57)
@sebthom sebthom marked this pull request as ready for review November 3, 2022 12:36
@sebthom
Copy link
Member Author

sebthom commented Nov 3, 2022

@rubenporras yes it's ready now.

@sebthom sebthom merged commit a75e770 into eclipse-lsp4e:master Nov 3, 2022
@sebthom sebthom deleted the UI branch November 3, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants