Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide new signature to open URI without UI.getActivePage() #283

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Provide new signature to open URI without UI.getActivePage() #283

merged 1 commit into from
Nov 7, 2022

Conversation

angelozerr
Copy link
Contributor

Provide new signature to open URI without UI.getActivePage()

This PR provides new methods in LSPEclipseUtils without having IWorkbenchPage as parameter. The benefit with that is:

  • it simplifies a little the code.
  • it allows for another plugin to use open methods without redefining an utility class UI.getActivePage() since UI class is not exported.

rubenporras
rubenporras approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mickaelistria mickaelistria merged commit 402f443 into eclipse-lsp4e:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenporras rubenporras rubenporras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelozerr @rubenporras @mickaelistria