New API: Port HighlightReconcilingStrategy #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahmedneilhussain, does it look good to you? |
rubenporras
force-pushed
the
portHighlightReconcilingStrategy
branch
from
2cd3aa5 to
ce6ab5f
Compare
|
The change looks great to me. |
|
Unrelated to this change, is document highlight working correctly at the moment? I wasn't aware it was even implemented as an LSP feature until I dug into this code recently, because I've never seen it working. AIUI, this is the feature that should show e.g. other instances of a variable in scope when you click on one of them (as it does in Java). If I try this using corrosion then I can see the requests firing and the response coming back but never see any highlights. |
|
It works for me in the latest released LSP4E, but we use our own server, I cannot tell with corrosion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.