Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite start/stop loop - initialize launcherFuture early #611

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

BoykoAlex
Copy link
Contributor

Naive and simple fix for #610

@BoykoAlex
Copy link
Contributor Author

In case isActive() needs to be left alone as is, another option could be check isActive() || initializedFuture != null perhaps or perhaps brand new boolean flag isStarted which would become true when start() called and false when stop() is called as well as initially... Feedback is welcomed

@mickaelistria
Copy link
Contributor

I don't see isActive modified in this patch. But I think it'd be OK to modify it if it's missing 1 condition.

@BoykoAlex
Copy link
Contributor Author

BoykoAlex commented Apr 14, 2023

isActive() looks at launcherFuture value... isActive() will start returning true sooner than it used to (which is a good thing i think) before lsp4j jsonrpc Launcher is started (ls to client connection established?). This is what i meant by the change to isActive() - implementation not changed but behaviour is changed.

Please see if this something that can be merged :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants