Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce UI thread for open(...) call #612

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Enforce UI thread for open(...) call #612

merged 1 commit into from
Apr 18, 2023

Conversation

BoykoAlex
Copy link
Contributor

No description provided.

@mickaelistria
Copy link
Contributor

See also #584 ; @ghentschke which patch do you think is better?

@ghentschke
Copy link
Contributor

Hi, I prefer this change here by @BoykoAlex. My change has still two unit test errors. Haven't had the the time to check why.

@mickaelistria mickaelistria merged commit 307f175 into eclipse-lsp4e:master Apr 18, 2023
@mickaelistria
Copy link
Contributor

Thanks for the patch and the review.

@mickaelistria mickaelistria mentioned this pull request Apr 18, 2023
Closed
@sebthom sebthom mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BoykoAlex @mickaelistria @ghentschke