add LanguageServerWrapper#getProcessHandle() #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2023
|
Same thing for |
@angelozerr it is already made adaptable in this PR, no? |
sebthom
force-pushed
the
lswrapp-processhandle
branch
from
a82d9c6 to
cf359f8
Compare
@vrubezhny I added it now |
|
@sebthom Looks good to me. Having access to process handle is a good thing, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
LanguageServerWrapper#getProcessHandle()method and enriches the theLanguageServerWrapper#toString()info with the pid of the underlying LS process.The
LanguageServerWrapper#getProcessHandle()will also be useful when implementing a LanguageServers UI view to access information such as pid, working directory or command of the underlying LS process.