-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#909] Add missing keys for enabling go to next / previous annotation actions #910
[#909] Add missing keys for enabling go to next / previous annotation actions #910
Conversation
org.eclipse.lsp4e/plugin.xml
Outdated
colorPreferenceValue="212,212,212" presentationLayer="4" | ||
showInNextPrevDropdownToolbarAction="true" | ||
showInNextPrevDropdownToolbarActionKey="org.eclipse.lsp4e.read.showInNextPrevDropdownToolbarAction" | ||
isGoToNextNavigationTarget="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please keep the line indention of the document. That makes it easier to track the changes and keeps the original formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I reverted my line indentation changes. But I suggest to fix the indentation characters after merging the PR. Otherwise, mixing tabs and spaces leads to different indentation results depending on the IDE settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think we have a misunderstanding. I mean the newly added lines should use the same format as the lines from the existing document (tab instead of spaces for the new lines as well):
<extension point="org.eclipse.ui.editors.markerAnnotationSpecification">
<specification annotationType="org.eclipse.lsp4e.read"
label="LSP Read Occurrence"
textPreferenceKey="LSP4EReadOccurrenceIndication" textPreferenceValue="false"
highlightPreferenceKey="LSP4EReadOccurrenceHighlighting"
highlightPreferenceValue="true" contributesToHeader="false"
overviewRulerPreferenceKey="LSP4EReadOccurrenceIndicationInOverviewRuler"
overviewRulerPreferenceValue="true"
verticalRulerPreferenceKey="LSP4EReadOccurrenceIndicationInVerticalRuler"
verticalRulerPreferenceValue="false" colorPreferenceKey="LSP4EReadOccurrenceIndicationColor"
colorPreferenceValue="212,212,212" presentationLayer="4"
showInNextPrevDropdownToolbarAction="true"
showInNextPrevDropdownToolbarActionKey="org.eclipse.lsp4e.read.showInNextPrevDropdownToolbarAction"
isGoToNextNavigationTarget="true"
isGoToNextNavigationTargetKey="org.eclipse.lsp4e.read.isGoToNextNavigationTarget"
isGoToPreviousNavigationTarget="true"
isGoToPreviousNavigationTargetKey="org.eclipse.lsp4e.read.isGoToPreviousNavigationTarget"
textStylePreferenceKey="LSP4EReadOccurrenceTextStyle"
textStylePreferenceValue="NONE">
</specification>
</extension>
Otherwise, mixing tabs and spaces leads to different indentation results depending on the IDE settings.
Yes, this should be done in a separate issue, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adapted the white space indentation characters to those previously used, tabs in this case.
@mickaelistria any other concerns from your side? |
No concern at all, feel free to merge whenever you're ready. |
Should make PR review easier
3474eac
to
c1bd7fe
Compare
@travkin79 Thank you! |
Fix for #909