Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NPE by asynchronous threads after the plug-in has been stop #968

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

rubenporras
Copy link
Contributor

No description provided.

@rubenporras
Copy link
Contributor Author

@mickaelistria , I am wondering if instead of not logging anything after the plugin has been stop, we should rather use this as a fallback. I can imagine we are still able to log even if the plug-in has been stop, but probably that is not desired.

@rubenporras
Copy link
Contributor Author

Failed tests are flaky tests. The job passed already twice.

@rubenporras rubenporras merged commit c53bbbb into eclipse-lsp4e:master Apr 18, 2024
1 of 2 checks passed
@rubenporras rubenporras deleted the logNPE branch April 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant