added archunit tests for no xbase/xtend/guava dep

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>

gradle/versions.gradle

@@ -20,5 +20,6 @@ ext.versions = [
 	'gson_orbit': '2.10.1.v20230109-0753',
 	'websocket_jakarta': '2.0.0',
 	'websocket': '1.0',
-	'junit': '4.13.2'
+	'junit': '4.13.2',
+	'archunit': '1.0.1'
 ]

org.eclipse.lsp4j.debug/build.gradle

@@ -19,6 +19,7 @@ dependencies {
 	testImplementation "junit:junit:$versions.junit"
 	testImplementation "org.eclipse.xtend:org.eclipse.xtend.lib:$versions.xtend_lib"
 	testImplementation project(":org.eclipse.lsp4j.generator")
+	testImplementation "com.tngtech.archunit:archunit:$versions.archunit"
 }
 
 jar {

org.eclipse.lsp4j.debug/src/test/java/org/eclipse/lsp4j/debug/test/Lsp4jDebugArchitectureTest.java

@@ -0,0 +1,69 @@
+package org.eclipse.lsp4j.debug.test;
+
+import static com.tngtech.archunit.core.domain.JavaClass.Predicates.resideInAPackage;
+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.noClasses;
+import static com.tngtech.archunit.base.DescribedPredicate.not;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import com.tngtech.archunit.core.domain.JavaClasses;
+import com.tngtech.archunit.core.importer.ClassFileImporter;
+import com.tngtech.archunit.lang.ArchRule;
+
+/**
+ * Test to make sure we don't depend to xbase.lib, xtend.lib and guava at
+ * runtime
+ * 
+ * @author Christian Dietrich
+ */
+public class Lsp4jDebugArchitectureTest {
+
+	private static JavaClasses importedClasses;
+
+	@BeforeClass
+	public static void scan() {
+		importedClasses = new ClassFileImporter().importPackages("org.eclipse.lsp4j.debug");
+	}
+
+	@AfterClass
+	public static void cleanup() {
+		importedClasses = null;
+	}
+
+	@Test
+	public void testNoDependenyToXbaseLib() {
+		assertNoDependencyToPackage("org.eclipse.xtext..");
+	}
+
+	@Test
+	public void testNoDependenyToXtendLib() {
+		assertNoDependencyToPackage("org.eclipse.xtend..");
+	}
+
+	@Test
+	public void testNoDependenyToXtend2Lib() {
+		assertNoDependencyToPackage("org.eclipse.xtend2..");
+	}
+
+	@Test
+	public void testNoDependenyToGuava() {
+		assertNoDependencyToPackage("com.google.common..");
+	}
+
+	@Test
+	public void testNoDependenyToGenerator() {
+		assertNoDependencyToPackage("org.eclipse.lsp4j.generator..");
+	}
+
+	private void assertNoDependencyToPackage(String badPackage) {
+		ArchRule rule = noClasses()
+				.that(resideInAPackage("org.eclipse.lsp4j.debug..")
+						.and(not(resideInAPackage("org.eclipse.lsp4j.generator.."))))
+				.and(not(resideInAPackage("org.eclipse.lsp4j.debug.test.."))).should().dependOnClassesThat()
+				.resideInAPackage(badPackage);
+		rule.check(importedClasses);
+	}
+
+}

org.eclipse.lsp4j/build.gradle

@@ -21,6 +21,7 @@ dependencies {
 	api project(":org.eclipse.lsp4j.jsonrpc")
 	testImplementation "junit:junit:$versions.junit"
 	testImplementation project(":org.eclipse.lsp4j.generator")
+	testImplementation "com.tngtech.archunit:archunit:$versions.archunit"
 }
 
 jar {

org.eclipse.lsp4j/src/test/java/org/eclipse/lsp4j/test/Lsp4jArchitectureTest.java

@@ -0,0 +1,80 @@
+/******************************************************************************
+ * Copyright (c) 2023 itemis AG and others.
+ * 
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v. 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0,
+ * or the Eclipse Distribution License v. 1.0 which is available at
+ * http://www.eclipse.org/org/documents/edl-v10.php.
+ * 
+ * SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause
+ ******************************************************************************/
+package org.eclipse.lsp4j.test;
+
+import static com.tngtech.archunit.core.domain.JavaClass.Predicates.resideInAPackage;
+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.noClasses;
+import static com.tngtech.archunit.base.DescribedPredicate.not;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import com.tngtech.archunit.core.domain.JavaClasses;
+import com.tngtech.archunit.core.importer.ClassFileImporter;
+import com.tngtech.archunit.lang.ArchRule;
+
+/**
+ * Test to make sure we don't depend to xbase.lib, xtend.lib and guava at
+ * runtime
+ * 
+ * @author Christian Dietrich
+ */
+public class Lsp4jArchitectureTest {
+
+	private static JavaClasses importedClasses;
+
+	@BeforeClass
+	public static void scan() {
+		importedClasses = new ClassFileImporter().importPackages("org.eclipse.lsp4j");
+	}
+
+	@AfterClass
+	public static void cleanup() {
+		importedClasses = null;
+	}
+
+	@Test
+	public void testNoDependenyToXbaseLib() {
+		assertNoDependencyToPackage("org.eclipse.xtext..");
+	}
+
+	@Test
+	public void testNoDependenyToXtendLib() {
+		assertNoDependencyToPackage("org.eclipse.xtend..");
+	}
+
+	@Test
+	public void testNoDependenyToXtend2Lib() {
+		assertNoDependencyToPackage("org.eclipse.xtend2..");
+	}
+
+	@Test
+	public void testNoDependenyToGuava() {
+		assertNoDependencyToPackage("com.google.common..");
+	}
+
+	@Test
+	public void testNoDependenyToGenerator() {
+		assertNoDependencyToPackage("org.eclipse.lsp4j.generator..");
+	}
+
+	private void assertNoDependencyToPackage(String badPackage) {
+		ArchRule rule = noClasses()
+				.that(resideInAPackage("org.eclipse.lsp4j..")
+						.and(not(resideInAPackage("org.eclipse.lsp4j.generator.."))))
+				.and(not(resideInAPackage("org.eclipse.lsp4j.test.."))).should().dependOnClassesThat()
+				.resideInAPackage(badPackage);
+		rule.check(importedClasses);
+	}
+
+}