Use Java 11 #707
Use Java 11 #707
Conversation
|
Can one of the admins verify this patch? |
|
@eclipse-lsp4j-bot run tests |
|
Note that this change needs CI updates too as CI uses Java 8. |
|
@eclipse-lsp4j-bot run tests |
That won't work as the PR job doesn't use Jenkinsfile. Landing #706 first may help here. |
|
@jonahgraham as our pr build do this "run on top thing" |
That is a good solution. Alternatively change the JDK in the PR job now. |
| @@ -7,7 +7,7 @@ pipeline { | |||
| } | |||
| tools { | |||
| maven 'apache-maven-latest' | |||
| jdk 'oracle-jdk8-latest' | |||
There was a problem hiding this comment.
can you also adapt the 2nd jenkinsfile
|
https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/mickaelistria-java-11/ is green |
@mickaelistria can you please explain the problem you're going to solve here from an lsp4j maintainers point of view? If I understand it correctly, this change will only make the next release incompatible to Java8 without any other user observable modifications? |
|
On #705 , I was encouraged to switch to Java 11 by @jonahgraham who referred to #547 . Supporting less versions is naturally reducing the target/scope of the project and thus reducing the amount of combination that are supposedly supported, thus decreasing the support cost; moving to newer versions enables to use newer feature languages which are most often more powerful or less error-prone, allow to keep the code more modern and more appealing to new contributors. |
|
@eclipse-lsp4j-bot run tests |
|
@mickaelistria A link in the commit message would have rendered my question obsolete, I guess. |
I added the missing "Fixes..." |
releng/build.Jenkinsfile
Outdated
| @@ -7,7 +7,7 @@ pipeline { | |||
| } | |||
| tools { | |||
| maven 'apache-maven-latest' | |||
| jdk 'oracle-jdk8-latest' | |||
| jdk 'openjdk-jdk11-latest' | |||
There was a problem hiding this comment.
openjdk latest is not a good idea, it is not kept up to date. Use adopt instead.
There was a problem hiding this comment.
yes temurin-jdk11-latest
|
@eclipse-lsp4j-bot run tests |
|
Coool!! |
Fixes #547