Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run workflow on Windows, macOS and Linux #736

Merged
merged 2 commits into from
May 29, 2023
Merged

Conversation

jonahgraham
Copy link
Contributor

This is to provide a test bench for #734 and to help prevent any fix for #734 from regressing.

@cdietrich
Copy link
Contributor

@jonahgraham can you check if my patch works with that?

@nixel2007
Copy link
Contributor

nixel2007 commented May 29, 2023

You could add macos too, cause it may have some os-specific behavior in uri and path handling (and yes, lsp4j is used on macos setups as part of bsl language server)

@jonahgraham
Copy link
Contributor Author

@jonahgraham can you check if my patch works with that?

I am looking at that now - I couldn't get your patch to work, but #737 has an alternative I am trying to verify.

You could add macos too, cause it may has some os-specific behavior in uri and path handling (and yes, lsp4j is used on macos setups as part of bsl language server)

OK, will do.

@jonahgraham jonahgraham force-pushed the jonah/run_on_windows_too branch from d734d92 to 6228349 Compare May 29, 2023 18:54
@jonahgraham jonahgraham changed the title Run workflow on Windows and Linux Run workflow on Windows, macOS and Linux May 29, 2023
@jonahgraham jonahgraham force-pushed the jonah/run_on_windows_too branch from 6228349 to b887c89 Compare May 29, 2023 18:56
@jonahgraham jonahgraham merged commit b887c89 into main May 29, 2023
@jonahgraham jonahgraham deleted the jonah/run_on_windows_too branch December 5, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants