Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ClassCastException when handling "textDocument/inlineValue" event #867

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

sebthom
Copy link
Contributor

@sebthom sebthom commented Jan 26, 2025

Addresses #866

Copy link
Contributor

@pisv pisv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 My apology for this bug, and thanks a lot for fixing it up!

@pisv pisv added this to the 0.24.0 milestone Jan 27, 2025
@pisv pisv merged commit db85990 into eclipse-lsp4j:main Jan 27, 2025
4 checks passed
@sebthom
Copy link
Contributor Author

sebthom commented Jan 27, 2025

@pisv do you think a new lsp4j release can be created in the foreseeable future?

@pisv
Copy link
Contributor

pisv commented Jan 27, 2025

@sebthom As far as I know, #834 (comment) is the current information on this topic. If you have input on when the new release would align well with your schedule, you can comment on #834.

In the meantime, the latest integration build with the fix is available at https://download.eclipse.org/lsp4j/builds/main/.

@sebthom sebthom mentioned this pull request Jan 27, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException Either3 cannot be cast to InlineValue when handling "textDocument/inlineValue" event
2 participants