Allow square brackets to specify options in a subset #7260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the user to specify options in a subset using
square brackets as opposed to normal brackets which is the norm.
E.g.: -Xjit:{methodRegex}[options-to-use]
Normal (round) brackets will continue to work as before.
Issue: eclipse-omr#7257
Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
@dsouzai Could you please review this PR? Thanks |
dsouzai
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Functionally lgtm; however, probably worth adding a couple of tests. I think adding a test to https://github.com/eclipse/omr/blob/master/fvtest/compilertest/tests/OptionSetTest.cpp with square brackets should suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the user to specify options in a subset using square brackets as opposed to normal brackets which is the norm. E.g.: -Xjit:{methodRegex}[options-to-use]
Normal (round) brackets will continue to work as before.
Issue: #7257