Improve VPClass::mustBeNotEqual() #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow reference comparisons to be folded to "not equal" more often. Previously VPClass::mustBeNotEqual() would return true only when the constraints could be distinguished by: - known null vs. known non-null, - known object index (when both are known to be non-null), or - fixed-class class pointer (when both are known to be non-null). Now most of the cases where it returns true require only one of the two constraints to forbid null. Additionally, the constraints can now also be distinguished by: - location (heap, stack, class object), - array element size, - array length, - class object type bound (non-fixed), and - instance type bound (fixed or not).
vijaysun-omr
approved these changes
Jul 29, 2024
|
Jenkins build all |
|
Jenkins build win |
|
Windows issue is infra related. Other checks have passed, and so I am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow reference comparisons to be folded to "not equal" more often. Previously
VPClass::mustBeNotEqual()would return true only when the constraints could be distinguished by:Now most of the cases where it returns true require only one of the two constraints to forbid null. Additionally, the constraints can now also be distinguished by: