Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK19 java/lang/Thread/virtual/PreviewFeaturesNotEnabled.java failed #16044

Closed
thallium opened this issue Oct 5, 2022 · 3 comments
Closed

JDK19 java/lang/Thread/virtual/PreviewFeaturesNotEnabled.java failed #16044

thallium opened this issue Oct 5, 2022 · 3 comments
Assignees
Labels
jdk19 project:loom Used to track Project Loom related work test failure

Comments

@thallium
Copy link
Contributor

thallium commented Oct 5, 2022

Failed with and without JIT

test PreviewFeaturesNotEnabled.testContinuationInitializer(): failure
java.lang.AssertionError: Expected ExceptionInInitializerError to be thrown, but nothing was thrown
        at org.testng.Assert.expectThrows(Assert.java:1730)
        at PreviewFeaturesNotEnabled.testContinuationInitializer(PreviewFeaturesNotEnabled.java:77)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
        at java.base/java.lang.reflect.Method.invoke(Method.java:578)
        at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
        at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
        at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
        at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
        at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
        at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
        at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
        at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
        at org.testng.TestRunner.privateRun(TestRunner.java:764)
        at org.testng.TestRunner.run(TestRunner.java:585)
        at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
        at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
        at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
        at org.testng.SuiteRunner.run(SuiteRunner.java:286)
        at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
        at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
        at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
        at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
        at org.testng.TestNG.runSuites(TestNG.java:1069)
        at org.testng.TestNG.run(TestNG.java:1037)
        at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:93)
        at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:53)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
        at java.base/java.lang.reflect.Method.invoke(Method.java:578)
        at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:125)
        at java.base/java.lang.Thread.run(Thread.java:1573)
test PreviewFeaturesNotEnabled.testIsVirtual(): success
test PreviewFeaturesNotEnabled.testNewVirtualThreadPerTaskExecutor(): success
test PreviewFeaturesNotEnabled.testOfPlatform(): success
test PreviewFeaturesNotEnabled.testOfVirtual(): success
test PreviewFeaturesNotEnabled.testStartVirutalThread(): success
@pshipton pshipton added the jdk19 label Oct 6, 2022
@pshipton pshipton added this to the Java 19 milestone Oct 6, 2022
@babsingh
Copy link
Contributor

babsingh commented Oct 6, 2022

The following checks are needed in Continuation.java for the above test to succeed.

import jdk.internal.misc.PreviewFeatures;
...
static {
    ContinuationSupport.ensureSupported();
    PreviewFeatures.ensureEnabled();
}

@fengxue-IS is currently working on this.

@fengxue-IS fengxue-IS added the project:loom Used to track Project Loom related work label Oct 6, 2022
@fengxue-IS fengxue-IS self-assigned this Oct 6, 2022
@fengxue-IS fengxue-IS modified the milestones: Java 19, Backlog Oct 6, 2022
@fengxue-IS
Copy link
Contributor

per discussion, moving this to backlog as the preview check is not blocking functionality

@DanHeidinga DanHeidinga modified the milestones: Backlog, Java 21 Apr 19, 2023
@babsingh
Copy link
Contributor

babsingh commented Jul 25, 2023

java/lang/Thread/virtual/PreviewFeaturesNotEnabled no longer exists in https://github.com/ibmruntimes/openj9-openjdk-jdk21 since Virtual Threads is no longer a preview and will GA in JDK21.

babsingh added a commit to babsingh/aqa-tests that referenced this issue Jul 25, 2023
java/lang/Thread/virtual/PreviewFeaturesNotEnabled no longer exists in
https://github.com/ibmruntimes/openj9-openjdk-jdk21 since Virtual
Threads is no longer a preview and will GA in JDK21.

Related: eclipse-openj9/openj9#16044

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
LongyuZhang pushed a commit to adoptium/aqa-tests that referenced this issue Jul 25, 2023
…4685)

java/lang/Thread/virtual/PreviewFeaturesNotEnabled no longer exists in
https://github.com/ibmruntimes/openj9-openjdk-jdk21 since Virtual
Threads is no longer a preview and will GA in JDK21.

Related: eclipse-openj9/openj9#16044

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jdk19 project:loom Used to track Project Loom related work test failure
Projects
None yet
Development

No branches or pull requests

5 participants