Fix GetThreadState to return correct state for carrier thread #16805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipak-bagadiya
force-pushed
the
virtual-thread-suspend-resume-fix
branch
from
fb47bda
to
0078a57
Compare
|
@babsingh requesting you to please review |
babsingh
changed the title
babsingh
reviewed
Mar 1, 2023
JVMTI GetThreadState returns 0 (invalid state) for carrier threads when a virtual thread is mounted over them. 0 indicates that the thread has not started but this state is invalid for the carrier threads when they have a virtual thread mounted. Helper function getThreadState should not be given virtual thread objects. It should only receive platform thread objects. Instead of targetThread->threadObject which can be a virtual thread object, it is given targetThread->carrierThreadObject to correctly evaluate the state of carrier threads. This change should also be compatible with all platform threads since carrierThreadObject is set only once during thread creation, and it stays the same until thread termination. Related: eclipse-openj9#16690 Signed-off-by: Dipak Bagadiya <dipak.bagadiya@ibm.com>
dipak-bagadiya
force-pushed
the
virtual-thread-suspend-resume-fix
branch
from
0078a57
to
8134e18
Compare
|
jenkins test sanity alinux64 jdk19 |
|
jenkins test sanity xlinux jdk8 |
babsingh
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
@dipak-bagadiya has verified locally that #16690 is fixed with this PR. #16690 will be closed after the test is re-enabled.
dipak-bagadiya
added a commit
to dipak-bagadiya/aqa-tests
that referenced
this pull request
Mar 3, 2023
Test had been fixed by eclipse-openj9/openj9#16805 Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com
dipak-bagadiya
added a commit
to dipak-bagadiya/aqa-tests
that referenced
this pull request
Mar 3, 2023
The test has been fixed by eclipse-openj9/openj9#16805. Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Mar 3, 2023
The test has been fixed by eclipse-openj9/openj9#16805. Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com
|
@dipak-bagadiya This fix is needed for the JDK19 release. Can you create a PR to deliver this fix in the 0.37 release branch: https://github.com/eclipse-openj9/openj9/tree/v0.37.0-release? |
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JVMTI GetThreadState returns 0 (invalid state) for carrier threads
when a virtual thread is mounted over them. 0 indicates that the
thread has not started but this state is invalid for the carrier
threads when they have a virtual thread mounted.
Helper function getThreadState should not be given virtual thread
objects. It should only receive platform thread objects. Instead of
targetThread->threadObject which can be a virtual thread object, it is
given targetThread->carrierThreadObject to correctly evaluate the
state of carrier threads. This change should also be compatible with
all platform threads since carrierThreadObject is set only once during
thread creation, and it stays the same until thread termination.
Related: #16690
Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com