[FFI/JDK22] Pass the heap segments to native in downcall #18930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR has been verified with the internal & OpenJ9 test suites, including the Jtreg test suite (related to the heap arguments) for JDK22 at https://github.com/ibmruntimes/openj9-openjdk-jdk22/tree/master/test/jdk/java/foreign/critical: |
|
Reviewer: @tajila |
ChengJin01
pushed a commit
to ChengJin01/aqa-tests
that referenced
this pull request
Feb 9, 2024
The change enables the FFI specific test suites in JDK22+ given the issue with the heap arguments is resolved via eclipse-openj9/openj9#18930. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
keithc-ca
reviewed
Feb 9, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
keithc-ca
reviewed
Feb 9, 2024
LongyuZhang
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Feb 9, 2024
The change enables the FFI specific test suites in JDK22+ given the issue with the heap arguments is resolved via eclipse-openj9/openj9#18930. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
4 times, most recently
from
ca4d7fd
to
680469f
Compare
keithc-ca
requested changes
Feb 12, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
test/functional/Java22andUp/src/org/openj9/test/jep454/downcall/InvalidDownCallTests.java
Outdated
Show resolved
Hide resolved
test/functional/Java22andUp/src/org/openj9/test/jep454/downcall/PrimitiveTypeTests1.java
Show resolved
Hide resolved
test/functional/Java22andUp/src/org/openj9/test/jep454/downcall/PrimitiveTypeTests2.java
Show resolved
Hide resolved
test/functional/Java22andUp/src/org/openj9/test/jep454/downcall/StructTests2.java
Show resolved
Hide resolved
test/functional/Java22andUp/src/org/openj9/test/jep454/upcall/InvalidUpCallTests.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
from
680469f
to
c0b39e6
Compare
keithc-ca
reviewed
Feb 13, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/UpcallMHMetaData.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
5 times, most recently
from
39486a5
to
59ac785
Compare
|
@amicic FYI |
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
from
59ac785
to
3ddfd2a
Compare
keithc-ca
requested changes
Feb 15, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
from
3ddfd2a
to
54280a9
Compare
keithc-ca
requested changes
Feb 16, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
from
54280a9
to
e196001
Compare
keithc-ca
requested changes
Feb 16, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
from
e196001
to
7b5b08a
Compare
keithc-ca
reviewed
Feb 20, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
from
7b5b08a
to
fcd32fd
Compare
keithc-ca
reviewed
Feb 20, 2024
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Show resolved
Hide resolved
The changes aim to pass the heap arguments to native when the linker option intended for the critical downcall is specified. Note: The feature implemented in this PR is specified in JEP454/JDK22 at eclipse-openj9#17872 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_jtreg_critical_pass_heap_to_native_jdk22_v2
branch
from
fcd32fd
to
7780020
Compare
keithc-ca
approved these changes
Feb 21, 2024
|
Jenkins test sanity amac jdk21,jdk22 |
|
@tajila Could you please approve this? |
tajila
approved these changes
Feb 21, 2024
ChengJin01
pushed a commit
to ChengJin01/aqa-tests
that referenced
this pull request
Feb 23, 2024
The changes enable the heap related test suites in JDK22+ given the problems with the tests are resolved via: [1] eclipse-openj9/openj9#18930 [2] eclipse-openj9/openj9#19002 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Feb 23, 2024
The changes enable the heap related test suites in JDK22+ given the problems with the tests are resolved via: [1] eclipse-openj9/openj9#18930 [2] eclipse-openj9/openj9#19002 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
|
This and #19002 need to be double delivered to the v0.44.0-release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes aim to pass the heap arguments
to native when the linker option intended
for the critical downcall is specified.
Fixes: #18939
Note:
The feature implemented in this PR is specified
in JEP454/JDK22 at #17872 .
Signed-off-by: ChengJin01 jincheng@ca.ibm.com