Use RSSReport class

[gita-omr]

No description provided.

[dsouzai]

I'm not sure it makes sense for this to go into 0.46 since this seems to be a non functional (i.e., reporting) feature rather than a bug fix, esp since the depending OMR change likely needs some non-trivial changes. Is there a strong reason to get this into 0.46?

[gita-omr]

I'm not sure it makes sense for this to go into 0.46 since this seems to be a non functional (i.e., reporting) feature rather than a bug fix, esp since the depending OMR change likely needs some non-trivial changes. Is there a strong reason to get this into 0.46?

I would say it does add a new feature (under an option). We planned to get it into 0.46 - just were a bit late.

[pshipton]

FYI there are conflicts that need to be resolved before this is merged.

I don't have any objection to putting this in 0.46 as long as this is merged to master and there are no resulting problems. My understanding is it's disabled by default, we haven't started any Milestone builds for 0.46 yet, and we're well in advance of M2. If we are putting it in, it would be nice to have it in before we start M1 builds next week.

[gita-omr]

Addressed OMR comments and rebased.

[gita-omr]

Thanks for the review. I will address it shortly. I decided to make this PR WIP and include ability to use this class from VM as well.

[gita-omr]

Rebased.

[gita-omr]

I think I addressed all the comments and I am not planning on adding any new interfaces to that class right now. @dsouzai @mpirvu could you please take another look?

[gita-omr]

Track the whole Code Cache vs just cold part.

[gita-omr]

Addressed latest comments

[gita-omr]

Rebased

[gita-omr]

Added check for rssReport != NULL inside jitAddNewLowToHighRSSRegion().

[gita-omr]

Addressed latest comments

[mpirvu]

The commits should be squashed into one.

[gita-omr]

Squashed all the commits.

[dsouzai]

jenkins test sanity.functional all jdk21

[dsouzai]

@gita-omr the builds are failing due to:

[2024-07-11T14:05:10.969Z] In file included from /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/control/CompilationThread.hpp:38,
[2024-07-11T14:05:10.969Z]                  from /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/net/ServerStream.hpp:29,
[2024-07-11T14:05:10.969Z]                  from /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/control/CompilationRuntime.hpp:45,
[2024-07-11T14:05:10.969Z]                  from /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/../compiler/codegen/J9CodeGenerator.hpp:45,
[2024-07-11T14:05:10.969Z]                  from /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/x/codegen/J9CodeGenerator.hpp:26,
[2024-07-11T14:05:10.969Z]                  from /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/x/amd64/codegen/J9CodeGenerator.hpp:39,
[2024-07-11T14:05:10.969Z]                  from /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/codegen/CodeGenGC.cpp:34:
[2024-07-11T14:05:10.970Z] /home/jenkins/workspace/Build_JDK21_x86-64_linux_Personal/openj9/runtime/compiler/runtime/DataCache.hpp:29:10: fatal error: runtime/OMRRSSReport.hpp: No such file or directory
[2024-07-11T14:05:10.970Z]    29 | #include "runtime/OMRRSSReport.hpp"
[2024-07-11T14:05:10.970Z]       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
[2024-07-11T14:05:10.970Z] compilation terminated.

[dsouzai]

This PR will conflict with #19850 once that's been merged.

[gita-omr]

Rebased and removed dependency from the description.

[gita-omr]

Not sure why OMRRSSReport.hpp was not found. Maybe eclipse-omr/omr#7349 was not picked up by the build yet.

[dsouzai]

jenkins compile xlinux jdk21

[dsouzai]

jenkins test sanity.functional all jdk21

[gita-omr]

The windows build failure seems to be unrelated.

[dsouzai]

The windows build failure seems to be unrelated.

Windows machines are all down right now. Everything else passed so will merge.