-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK17+ JVM_LoadLibrary() opens shared library via J9PORT_SLOPEN_DECORATE #19861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Jul 18, 2024
JasonFengJ9
force-pushed
the
aixlib
branch
2 times, most recently
from
July 23, 2024 17:17
b0c2289
to
ce0a760
Compare
keithc-ca
requested changes
Jul 24, 2024
keithc-ca
reviewed
Jul 25, 2024
j9sl_open_shared_library() with the flag J9PORT_SLOPEN_DECORATE expects the incoming library name to be platform independent, i.e., it must not contain any prefix or file extension. A path to the library is supported. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
Jenkins test sanity aix,amac,xlinux,win jdk11,jdk17 |
I keep forgetting we have no Windows build systems (online). I'll rely on the test results for the other platforms. |
keithc-ca
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK17+
JVM_LoadLibrary()
opens shared library viaJ9PORT_SLOPEN_DECORATE
j9sl_open_shared_library()
with the flagJ9PORT_SLOPEN_DECORATE
expects the incoming library name to be platform independent, i.e., it must not contain any prefix or file extension. A path to the library is supported.Required by
closes #19344
Signed-off-by: Jason Feng fengj@ca.ibm.com