Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Unsafe value type comments and Java methods #19915

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

theresa-m
Copy link
Contributor

  • update comments using primitive language
  • remove stale methods getReferenceVolatile and getReference
  • add methods hasNullMarker and nullMarkerOffset to match RI

Related: #19677

@theresa-m theresa-m marked this pull request as ready for review July 24, 2024 14:15
@theresa-m theresa-m requested a review from hangshao0 July 24, 2024 14:15
@theresa-m theresa-m added comp:vm project:valhalla Used to track Project Valhalla related work labels Jul 24, 2024
- update comments with primitive references
- remove stale methods getReferenceVolatile and getReference
- add methods hasNullMarker and nullMarkerOffset to match RI

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@hangshao0
Copy link
Contributor

Jenkins compile alinuxval jdknext

@hangshao0
Copy link
Contributor

Jenkins compile amac jdknext

@hangshao0
Copy link
Contributor

hangshao0 commented Jul 24, 2024

The error in the jdkNext build (not valhalla build) is:

share/classes/java/lang/Access.java:70: error: Access is not abstract and does not override abstract method stringConcatHelperPrepend(long,byte[],String) in JavaLangAccess

Looks like jdknext is 24 and this is causing the error:

/*[IF JAVA_SPEC_VERSION < 24]*/
@Override
public long stringConcatHelperPrepend(long indexCoder, byte[] buf, String value) {
return StringConcatHelper.prepend(indexCoder, buf, value);
}
/*[ENDIF] JAVA_SPEC_VERSION < 24 */

@JasonFengJ9

@JasonFengJ9
Copy link
Member

The openjdk change in question is ibmruntimes/openj9-openjdk-jdk@758ebfe

It hasn't been promoted into openj9 branch yet due to abuild failure https://openj9-jenkins.osuosl.org/job/Build_JDKnext_x86-64_linux_OpenJDK/708/consoleFull

Just restarted failed JDKnext_x86-64_linux build, if it passes, the change can be pulled in manually.

@JasonFengJ9
Copy link
Member

@hangshao0 can you retry the amac jdknext build?

@hangshao0
Copy link
Contributor

Jenkins compile amac jdknext

@hangshao0 hangshao0 merged commit d776a4a into eclipse-openj9:master Jul 25, 2024
5 checks passed
@theresa-m theresa-m deleted the unsafe_update branch October 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants