Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update number of frames for test_YieldedVirtualThreadGetStackTrace #19945

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

keithc-ca
Copy link
Contributor

JDK24 removed VirtualThreads.park() from the stack trace in

reducing the stack from 6 to 5 elements.

A recent failure can be seen in https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDKnext/284.

@keithc-ca keithc-ca requested a review from llxia July 30, 2024 20:07
@keithc-ca
Copy link
Contributor Author

Jenkins test sanity amac jdk23,jdknext

JDK24 removed VirtualThreads.park() from the stack trace.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
Copy link
Contributor Author

Jenkins test sanity amac jdk23,jdknext

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 5b6168a into eclipse-openj9:master Aug 1, 2024
7 checks passed
@keithc-ca keithc-ca deleted the yield branch August 1, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants