(0.48) Remove requirement for consistent memory page size in SCC #20183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The page level operation in SCC are msync and mprotect. msync is only used on z/OS for persistent cache, we can always do msync if we have a valid _osPageSize. For mprotect, it is turned off if the SCC is readonly. If the data is not paged aligned anymore, mprotect should be also be turned off. There is no need to force consistent memory page size between cold and warn runs anymore. 2. Add new test flags and command line test cases. 3. Add top layer page size infomation in cache stats. 4. Add page size info into javacore. Fixes eclipse-openj9#19968 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
|
@TobiAjila Could you merge this backport ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page level operation in SCC are msync and mprotect. msync is only used on z/OS for persistent cache, we can always do msync if we have a valid _osPageSize. For mprotect, it is turned off if the SCC is readonly. If the data is not paged aligned anymore, mprotect should be also be turned off. There is no need to force consistent memory page size between cold and warn runs anymore.
Add new test flags and command line test cases.
Add top layer page size infomation in cache stats.
Add page size info into javacore.
Fixes #19968
Port of #19972