Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish why AOT is disabled post-restore #20241

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Sep 26, 2024

Post-Restore, the AOT load and compilation disabled post restore. can be printed out either because AOT was disabled due to options/factors pre-checkpoint or options/factors post-restore. This PR adds a new NLS message to distinguish between these two scenarios.

#20233

@dsouzai dsouzai added comp:jit criu Used to track CRIU snapshot related work labels Sep 26, 2024
@dsouzai
Copy link
Contributor Author

dsouzai commented Sep 26, 2024

Jenkins test sanity.functional alinux64 jdk11

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai
Copy link
Contributor Author

dsouzai commented Sep 26, 2024

Jenkins test sanity.functional alinux64 jdk11

@dsouzai
Copy link
Contributor Author

dsouzai commented Sep 26, 2024

@ymanton could you review/merge?

@TobiAjila @pshipton

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I take it this will resolve cases where tests are spuriously failing because of

AOT load and compilation disabled post restore.

will now pass because the output will be

AOT load and compilation disabled pre-checkpoint and post-restore.

?

@ymanton
Copy link
Member

ymanton commented Sep 27, 2024

Disregard the above, looked at #20233 and that is indeed what should happen. Why is this only relevant to aarch64?

@dsouzai
Copy link
Contributor Author

dsouzai commented Sep 27, 2024

Why is this only relevant to aarch64?

My guess is that there's some kind of infra or config issue that's preventing the JIT from enabling AOT pre-checkpoint (eg, the SCC can't be validated, or there's no SCC, or whatever).

@ymanton ymanton merged commit ed75984 into eclipse-openj9:master Sep 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants