Change jvmtiGetAvailableProcessors to use J9PORT_CPU_TARGET #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a comment to both this method and to the JVM_ function to say the two implementations should be kept consistent? |
anikser
force-pushed
the
jvmti-get-available-processors-use-target
branch
from
37de50d to
b80ef11
Compare
DanHeidinga
reviewed
Jun 26, 2018
runtime/jvmti/jvmtiTimers.c
Outdated
| @@ -208,7 +208,8 @@ jvmtiGetAvailableProcessors(jvmtiEnv* env, | |||
|
|
|||
| ENSURE_NON_NULL(processor_count_ptr); | |||
|
|
|||
| cpuCount = j9sysinfo_get_number_CPUs_by_type(J9PORT_CPU_ONLINE); | |||
| /* This implementation should be kept consistent with JVM_ActiveProcessorCount */ | |||
| cpuCount = j9sysinfo_get_number_CPUs_by_type(J9PORT_CPU_TARGET); | |||
| *processor_count_ptr = ((cpuCount == 0) ? 1 : (jint) cpuCount); | |||
There was a problem hiding this comment.
To make the two consistent, can you modify the ((cpuCount == 0) to be ((cpuCount < 1)
This change causes `jvmtiGetAvailableProcessors` to behave identically to `JVM_ActiveProcessorCount`, also taking into account cgroup limits when appropriate as discussed in eclipse-openj9#1166. Signed-off-by: Mohammad Ali Nikseresht <anikser@ibm.com>
anikser
force-pushed
the
jvmti-get-available-processors-use-target
branch
from
b80ef11 to
e876642
Compare
DanHeidinga
approved these changes
Jun 26, 2018
|
Jenkins test sanity plinux jdk8 |
|
travis build failed for infra issues contacting sourceforge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes
jvmtiGetAvailableProcessorsto behave identicallyto
JVM_ActiveProcessorCount, also taking into account cgroup limitswhen appropriate as discussed in #1166.
Signed-off-by: Mohammad Ali Nikseresht anikser@ibm.com