Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E4 editr use inconsitent style for boolean parameters #1308

Closed
laeubi opened this issue Jun 18, 2024 · 3 comments · Fixed by #1465
Closed

E4 editr use inconsitent style for boolean parameters #1308

laeubi opened this issue Jun 18, 2024 · 3 comments · Fixed by #1465
Assignees
@emyuans
Labels
good first issue Good for newcomers

Comments

@laeubi
Copy link
Contributor

laeubi commented Jun 18, 2024 •
edited
Loading

Currently the E4 Editor looks like this:

grafik

Also in contrast to other things the colon : is missing.

I think this should be unified to always use

Label: [ ]

instead of

[ ] Label
iloveeclipse pushed a commit to iloveeclipse/eclipse.pde.ui that referenced this issue Jun 18, 2024
@N1k145 @fedejeanne
Adding Command Icon To Application Model Editor Tree eclipse-pde#1308
2dbe034 
Currently, Command Icons are not visible in the Tree of the Application Model Editor.
Icons of other Elements, like Parts, are visible in the Tree. This aligns this behavior.

Fixes eclipse-platform/eclipse.platform.ui#1308
@HannesWell HannesWell added the good first issue Good for newcomers label Aug 13, 2024
@emyuans
Copy link
Contributor

emyuans commented Oct 6, 2024

I'm working on this

@HannesWell
Copy link
Member

Great. You are one of the students from CodeDays, aren't you?

Much success on this task and don't hesitate to ask for help if you need any.

@basonbang
Copy link
Contributor

Hello, I had some confusion on how to access this part of the Eclipse development environment. How would we get to the E4 Editor within the UI as well as within the code itself?

@HannesWell HannesWell mentioned this issue Nov 14, 2024
Merged
stewedbeef added a commit to stewedbeef/eclipse.pde that referenced this issue Nov 22, 2024
@stewedbeef @basonbang @emyuans
Change checkboxes for E4 editor to have consistent placement and add …
d3dcd0e 
…colons in E4 editor menu items.

Fixes eclipse-pde#1308

Co-authored-by: Jason Tang <119823259+basonbang@users.noreply.github.com>
Co-authored-by: emyuans <147277376+emyuans@users.noreply.github.com>
stewedbeef added a commit to stewedbeef/eclipse.pde that referenced this issue Nov 22, 2024
@stewedbeef @basonbang @emyuans
Change checkboxes for E4 editor to have consistent placement and add …
cab611a 
…colons in E4 editor menu items.

Fixes eclipse-pde#1308

Co-authored-by: Jason Tang <jasontang20043@gmail.com>
Co-authored-by: Emily Yuan <emyuans@yahoo.com>
basonbang added a commit to stewedbeef/eclipse.pde that referenced this issue Nov 23, 2024
@stewedbeef @basonbang @emyuans
Change checkboxes for E4 editor to have consistent placement and add …
46be095 
…colons in E4 editor menu items.

Fixes eclipse-pde#1308

Co-authored-by: Jason Tang <jasontang20043@gmail.com>
Co-authored-by: Emily Yuan <emyuans@yahoo.com>
HannesWell pushed a commit to stewedbeef/eclipse.pde that referenced this issue Nov 27, 2024
@stewedbeef @basonbang
@emyuans @HannesWell
Change checkboxes for E4 editor to have consistent placement and add …
e99f87f 
…colons in E4 editor menu items.

Fixes eclipse-pde#1308

Co-authored-by: Jason Tang <jasontang20043@gmail.com>
Co-authored-by: Emily Yuan <emyuans@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyuans emyuans

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #1308: Fix E4 editor boolean parameters stewedbeef/eclipse.pde
4 participants
@laeubi @HannesWell @basonbang @emyuans