Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export package does not work when jar is not on classpath #885

Open
laeubi opened this issue Nov 6, 2023 · 4 comments · May be fixed by #1197
Open

Export package does not work when jar is not on classpath #885

laeubi opened this issue Nov 6, 2023 · 4 comments · May be fixed by #1197

Comments

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

Noticed to day that the export package button is disabled when one does the following:

  1. create a new plugin project but disable "create java project"
  2. then add a jar into that project
  3. add it to the Bundle Classpath
  4. Export package is not possible
@lathapatil
Copy link
Contributor

3. add it to the Bundle Classpath

in Runtime tab of Manifest editor?

4. Export package is not possible

If I am not wrong , as we have disabled java project creation we do not have any packages in the project right now. What do we export ?

@laeubi
Copy link
Contributor Author

laeubi commented Jan 5, 2024 •
edited
Loading

in Runtime tab of Manifest editor?

yes

If I am not wrong , as we have disabled java project creation we do not have any packages in the project right now.

Regardless of enabled java nature there are no packages in the project if you have just a jar on the Bundle-Classpath

What do we export ?

Any packages from the Bundle-Classpath are eligible for export in such situation.

@Dinesh0723
Copy link
Contributor

Should we need to enable export packages only for the project with plugin nature, or for the project containing the manifest file as well?

Dinesh0723 added a commit to Dinesh0723/eclipse.pde that referenced this issue Mar 14, 2024
@Dinesh0723
Export package does not work when jar is not on classpath
cd085c1 
Introduced new support for exporting packages in projects with plugin
nature as well.

Fixes: eclipse-pde#885
@Dinesh0723 Dinesh0723 linked a pull request Mar 14, 2024 that will close this issue
Open
@Dinesh0723
Copy link
Contributor

Introducing a new feature: Export package functionality is now enabled when JAR files are added to the classpath of projects with plugin nature, even if the Java nature is disabled.

laeubi pushed a commit to Dinesh0723/eclipse.pde that referenced this issue Apr 29, 2024
@Dinesh0723 @laeubi
Export package does not work when jar is not on classpath
3d80ca9 
Introduced new support for exporting packages in projects with plugin
nature as well.

Fixes: eclipse-pde#885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export package does not work when jar is not on classpath Dinesh0723/eclipse.pde
3 participants
@laeubi @lathapatil @Dinesh0723