Correct syntax for require in refactoring help file. #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139.
As noted in #139 the current documentation is wrong
require(RenFile1.php);
will error as it will be evaluated as two undefined constants (RenFile1
andphp
) and the concatenation operator (.
) which will cause a warning about each undefined constant and it will then try to concatenate these undefined constants. It will then try to require the fileRenFile1php
which will raise a fatal error (because usingrequire
, rather thaninclude
). Definitely more than unhelpful if the IDE help files don't use correct syntax for the examples!require
in PHP is a language level feature not a function, but I didn't update the syntax to the more usualrequire "file.php"
because the function-like syntax is also acceptable.