Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API errors on org.eclipse.ui.editors and org.eclipse.ui.workbench.texteditor #2430

Closed
iloveeclipse opened this issue Oct 21, 2024 · 5 comments · Fixed by #2431
Closed

API errors on org.eclipse.ui.editors and org.eclipse.ui.workbench.texteditor #2430

iloveeclipse opened this issue Oct 21, 2024 · 5 comments · Fixed by #2431
Assignees
@iloveeclipse
Labels
bug Something isn't working regression
Milestone
4.34 M3

Comments

@iloveeclipse
Copy link
Member

Regression from commit 9bd3284 / #2400

  • New constant was added in AbstractDecoratedTextEditorPreferenceConstants API (org.eclipse.ui.editors)
  • New method was added to SourceViewerDecorationSupport (org.eclipse.ui.workbench.texteditor)

In both cases minor segment version should have been updated. Interestingly, no checks failed...

I will push updated manifests.
@iloveeclipse iloveeclipse added bug Something isn't working regression labels Oct 21, 2024
@akurtakov
Copy link
Member

Maybe api tools are not "enabled" in/for some bundle?

@iloveeclipse iloveeclipse mentioned this issue Oct 21, 2024
Merged
iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Oct 21, 2024
@iloveeclipse
Fix API errors by updating bundle versions
ca6d1df 
Regression from commit 9bd3284 / eclipse-platform#2400

Also updated version range on bundle with increased version.

Fixes eclipse-platform#2430
@iloveeclipse
Copy link
Member Author

Maybe api tools are not "enabled" in/for some bundle?

But for both bundles?
I don't see pom in the related bundles, where are the API settings are taken from? Parent pom? I don't see any mention of API tooling there too, so I assume it should enabled by default?

@merks
Copy link
Contributor

merks commented Oct 21, 2024

The my Eclipse SDK IDE today after a pull shows these errors today:

image

@iloveeclipse
Copy link
Member Author

See #2431.

Once merged, I will trigger I build, also for eclipse-jdt/eclipse.jdt.core#3125.

@akurtakov
Copy link
Member

I was more thinking about .settings/.project configs. But now that I looked more into it - these are split packages so my gut feeling is that API tools fails thanks to that.

@iloveeclipse iloveeclipse self-assigned this Oct 21, 2024
@iloveeclipse iloveeclipse added this to the 4.34 M3 milestone Oct 21, 2024
@iloveeclipse iloveeclipse mentioned this issue Oct 22, 2024
Open
iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Oct 22, 2024
@iloveeclipse
DO NOT MERGE
e53c3c3 
Check if API tools are working in platform UI.

This PR should fail validation because it adds new API with wrong since
tag.

See eclipse-platform#2430
See eclipse-platform#1922
@iloveeclipse iloveeclipse mentioned this issue Oct 22, 2024
Closed
iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Oct 22, 2024
@iloveeclipse
DO NOT MERGE
972c6d0 
Check if API tools are working in platform UI.

This PR should fail validation because it adds new API with wrong since
tag.

See eclipse-platform#2430
See eclipse-platform#1922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
bug Something isn't working regression
Projects
None yet
Milestone
4.34 M3
Development

Successfully merging a pull request may close this issue.

Fix API errors by updating bundle versions iloveeclipse/eclipse.platform.ui
3 participants
@merks @akurtakov @iloveeclipse