-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find actions should use more modern filtering mechanism #741
Comments
Content assist suggestions does use this fuzzy searching (in JDT) with the preference Java -> Editor -> Content Assist -> Show subword matches. This request is to add the same type of searching to all other places. Ideally a solution to this problem would be done so all extensions that use this type of functionality can take advantage, e.g. PyDev and CDT's open type should be able to easily take advantage of this too. |
This would be relatively easy to implement, however it wouldn't be a general change; it would have to be particular to file match and then other matches... |
I think it can be the basis of a general change by enhancing SearchPattern to have a new search option that achieves the goal in #741 (comment). Then anywhere that searches can use the new API. This would be similar to what was done to enhance things in f31b811. Additionally, as @vogella said in #12 (comment):
|
Note that Eclipse IDE WG Funded Development Effort #21 has been raised to resolve this problem. |
@jonahgraham Please note that Java -> Editor -> Content Assist -> Show subword matches is very expensive and only works reasonable fast in small/medium workspaces. A more efficient implementation is needed if this is enabled at scale for Ctrl/Cmd+3 dialog. |
Thank you @guw for pointing that out. I think we should set some performance parameters. e.g. If we import all projects in simrel (all git repos in simrel.aggran imported as a single project) that is about 660,000 files. Is this a sufficiently big workspace? |
That sounds like a good example. Having a benchmark done to confirm the numbers not regressing will help. |
Related: #1241 |
Most modern editors use fuzzy searching or subsequence searching. This basically means they add wildcards in between characters allowing for the following:
AliasFormattingTest.java
aliasformtest
Right now this doesn't work,
Aliasform
works, and so thoseFormattingTest
butAformattingtest
doesn't again. This is a phenomenon that's very prevalent in Eclipse and makes it feel less modern. Ctrl+Shift+T and R, Ctrl + O, ... - Open Type, Open Resource, and Quick Outline in JDT - suffer from the same issue. Basically, if you don't know the name of the file you have to type wildcard*
all over your query.The text was updated successfully, but these errors were encountered: