Limit the visibility of "Find References" to the active Generic Editor #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility of this menu item must be restricted because other editors like the Xtext Editor come with their own "Find References" action. Fixes https://bugs.eclipse.org/bugs/show_bug.cgi?id=564610
oleosterhagen
force-pushed
the
find-references-visibility
branch
from
487cc3f to
d880351
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visibility of this menu item must be restricted because other editors like the Xtext Editor come with their own "Find References" action.
Fixes https://bugs.eclipse.org/bugs/show_bug.cgi?id=564610
Also referenced in https://gitlab.eclipse.org/eclipse-wg/ide-wg/ide-wg-dev-funded-efforts/ide-wg-dev-funded-program-planning-council-top-issues/-/issues/30
With this change the Xtext Editor only shows its own Find References action. I have also tested (with Typescript files) that this menu item is still visible and functional in the Generic Editor.