Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert o.e.ui.tests to plain JUnit 4 (part 3) #2424

Closed
wants to merge 1 commit into from

Conversation

akurtakov
Copy link
Member

Reduce inheritance, simplify setup/teardown, improve assertions, etc.

@akurtakov akurtakov self-assigned this Oct 19, 2024
Copy link
Contributor

github-actions bot commented Oct 19, 2024

Test Results

 1 821 files  +3   1 821 suites  +3   2h 38m 34s ⏱️ + 48m 2s
 7 711 tests ±0   7 395 ✅  - 87  228 💤 ±0  52 ❌ +51  36 🔥 +36 
24 294 runs  ±0  23 451 ✅  - 95  747 💤 ±0  52 ❌ +51  44 🔥 +44 

For more details on these failures and errors, see this check.

Results for commit 275f14f. ± Comparison against base commit 9f38380.

This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testFileWithNameConflictWithEditorClonedTwice
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testMultipleFilesWithNameCollisionAndEditorSplit
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testMultipleFilesWithNoNameConflict
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testMultipleFilesWithOneNameClash
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testMultipleFilesWithSharedParentFolders
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testMultipleFilesWithSharedParentFoldersButNotAllShareTheSameParentFolders
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testSingleFile
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testSingleFileWithEditorClonedTwice
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testSingleFileWithEditorSplit
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite ‑ testTwoFilesWithNameClash
…
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testFileWithNameConflictWithEditorClonedTwice
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testMultipleFilesWithNameCollisionAndEditorSplit
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testMultipleFilesWithNoNameConflict
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testMultipleFilesWithOneNameClash
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testMultipleFilesWithSharedParentFolders
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testMultipleFilesWithSharedParentFoldersButNotAllShareTheSameParentFolders
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testSingleFile
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testSingleFileWithEditorClonedTwice
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testSingleFileWithEditorSplit
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.WorkbookEditorsHandlerTest ‑ testTwoFilesWithNameClash
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
org.eclipse.ui.tests.intro.IntroPartTest ‑ Unknown test
org.eclipse.ui.tests.intro.IntroTestSuite ‑ org.eclipse.ui.tests.intro.IntroPartTest

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the master branch 11 times, most recently from 5f55681 to 275f14f Compare October 21, 2024 13:54
Reduce inheritance, simplify setup/teardown, improve assertions, etc.
@akurtakov
Copy link
Member Author

This became too big to land at once . Will try with far smaller chunks again.

@akurtakov akurtakov closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant